Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for diffrent mouse buttons in UI buttons #389

Closed
wants to merge 10 commits into from
Closed

Support for diffrent mouse buttons in UI buttons #389

wants to merge 10 commits into from

Conversation

TheRawMeatball
Copy link
Member

No description provided.

@karroffel karroffel added C-Feature A new feature, making something new possible A-Input Player input via keyboard, mouse, gamepad, and more A-UI Graphical user interfaces, styles, layouts, and widgets labels Aug 30, 2020
@CleanCut
Copy link
Member

CleanCut commented Aug 30, 2020 •
edited
Loading

It panics when I attempt to run the ui example on this branch with cargo run --example ui. See attached backtrace.

backtrace.txt

@TheRawMeatball
Copy link
Member Author

The example runs fine on my machine, and the backtrace suggests a missing font. Are you sure all assets are where they need to be?

@CleanCut
Copy link
Member

Hmm...the same command works fine now. Dunno what was wrong before, as I didn't do anything but checkout your branch of bevy. I withdraw my crash comment. 🤷‍♂️

@stefee stefee mentioned this pull request Aug 31, 2020
Open
memoryruins
memoryruins reviewed Sep 1, 2020
View reviewed changes
crates/bevy_input/src/mouse.rs Outdated Show resolved Hide resolved
crates/bevy_ui/src/focus.rs Outdated Show resolved Hide resolved
crates/bevy_ui/src/focus.rs Outdated Show resolved Hide resolved
examples/ui/button.rs Outdated Show resolved Hide resolved
@TheRawMeatball @memoryruins
Apply suggestions from code review
791c5ea 
Co-authored-by: memoryruins <memoryruinsmusic@gmail.com>
@memoryruins memoryruins mentioned this pull request Sep 3, 2020
Merged
@TheRawMeatball
Copy link
Member Author

Closing because of Axis API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefee stefee stefee left review comments

@memoryruins memoryruins memoryruins left review comments

Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more A-UI Graphical user interfaces, styles, layouts, and widgets C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheRawMeatball @CleanCut @memoryruins @stefee @karroffel